Skip to content
This repository has been archived by the owner on Mar 22, 2019. It is now read-only.

Add discussion forum to community navbar dropdown #3177

Closed
wants to merge 2 commits into from

Conversation

catgirlinspace
Copy link

This pull request adds a link to the discussion forum under the community dropdown.

@locks locks requested a review from MelSumner February 2, 2018 00:27
@@ -40,6 +40,7 @@
<li><a href="/community">The Ember Community</a>
<li><a href="/guidelines">Guidelines</a></li>
<li><a href="http://github.com/emberjs/">Contribute (Github)</a></li>
<li><a href="https://discuss.emberjs.com/">Ember Discussion Forum</a></li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! 👍

I think if we add a Forum link we should probably also add the Slack community link, but then again, both are front and center on the community page, which is already in this dropdown. @jenweber @acorncom any thoughts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MelSumner inclined to agree with you. While having both links easily findable in the menu would be handy, we need to curate the items in this list so we can help people clearly find major areas of the community. I'm inclined to say we don't want to merge this. @jenweber @locks ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am kinda torn. On one hand, I don't want to clutter the nav. On the other hand, new users need those links the most and I don't know that they would find them as-is. I would like to do an informal UX test before making a decision. I'll show some new devs our site, and ask them to find the discussion board/slack chat.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just thought it was a good idea because the discussion forum seemed hidden away.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dog2puppy do you think that if we simplified the Community page in general, it would be clearer for you? See #3156 & see what you think.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the community page would probably be better. When I made this pull request, it was when I figured out that the forum was hidden in the page and not on the navbar. I'll just close this pull request then.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants