Add support for device-type filter to starmer.

emfcamp · May 30, 2024 · fee3bc4 · fee3bc4
1 parent 80a5b07
commit fee3bc4
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 16 deletions.
diff --git a/configbuilders/starmer/cmd/access_switch_http_sd/main.go b/configbuilders/starmer/cmd/access_switch_http_sd/main.go
@@ -4,7 +4,9 @@ package main
 
 import (
 	"encoding/json"
+	"log"
 	"net/http"
+	"strings"
 
 	"github.com/netbox-community/go-netbox/v3"
 	"github.com/prometheus/prometheus/discovery/targetgroup"
@@ -23,9 +25,15 @@ func accessSwitchHttpSD(dcim *netbox.DcimAPIService) *http.HandlerFunc {
 	var handler http.HandlerFunc
 	handler = func(resp http.ResponseWriter, req *http.Request) {
 
+		dt := req.URL.Query().Get("device-type")
+		dts := []string{}
+		if dt != "" {
+			dts = strings.Split(dt, ",")
+		}
 		configs := make([]targetgroup.Group, 0)
-		sws, err := switchinfo.GetSwitchesWithRoles(req.Context(), dcim, []string{"access-switch", "distribution-switch"})
+		sws, err := switchinfo.GetSwitchesWithRoles(req.Context(), dcim, []string{"access-switch", "distribution-switch"}, dts)
 		if err != nil {
+			log.Printf("Error getting switches: %w", err)
 			resp.WriteHeader(500)
 			return
 		}

diff --git a/configbuilders/starmer/cmd/switch_dns/main.go b/configbuilders/starmer/cmd/switch_dns/main.go
@@ -14,7 +14,7 @@ const zone string = "net.emf.camp."
 
 func main() {
 	cl := cmdlib.GetNetboxClient()
-	switches, err := switchinfo.GetSwitchesWithRoles(context.TODO(), cl.DcimAPI, []string{"access-switch", "distribution-switch"})
+	switches, err := switchinfo.GetSwitchesWithRoles(context.TODO(), cl.DcimAPI, []string{"access-switch", "distribution-switch"}, []string{})
 
 	if err != nil {
 		log.Fatalf("Error getting access switches: %s", err)

diff --git a/configbuilders/starmer/switchinfo/devices.go b/configbuilders/starmer/switchinfo/devices.go
@@ -10,14 +10,15 @@ import (
 )
 
 type Switch struct {
-	Name string
-	MgmtIP netip.Addr
-	Loc Location
-	Status netbox.DeviceStatus
+	Name       string
+	MgmtIP     netip.Addr
+	Loc        Location
+	Status     netbox.DeviceStatus
+	DeviceType netbox.NestedDeviceType
 }
 
-func GetSwitchesWithRoles(ctx context.Context, dcim *netbox.DcimAPIService, roles []string) ([]Switch, error) {
-	req := dcim.DcimDevicesList(ctx).Role(roles).Limit(500)
+func GetSwitchesWithRoles(ctx context.Context, dcim *netbox.DcimAPIService, roles []string, deviceTypes []string) ([]Switch, error) {
+	req := dcim.DcimDevicesList(ctx).Role(roles).DeviceType(deviceTypes).Limit(500)
 
 	results := make([]Switch, 0)
 
@@ -35,14 +36,15 @@ func GetSwitchesWithRoles(ctx context.Context, dcim *netbox.DcimAPIService, role
 			nloc.Name,
 			orb.Point{52, 0},
 		}
-	
+
 		results = append(results, Switch{
-			Name: dev.GetName(),
-			MgmtIP: netip.MustParsePrefix(dev.GetPrimaryIp4().Address).Addr(),
-			Loc: loc,
-			Status: dev.GetStatus(),
+			Name:       dev.GetName(),
+			MgmtIP:     netip.MustParsePrefix(dev.GetPrimaryIp4().Address).Addr(),
+			Loc:        loc,
+			Status:     dev.GetStatus(),
+			DeviceType: dev.DeviceType,
 		})
-		
+
 	}
 
 	return results, nil

diff --git a/configbuilders/starmer/switchinfo/prometheus.go b/configbuilders/starmer/switchinfo/prometheus.go
@@ -16,9 +16,10 @@ func SwitchPromTarget(s *Switch) *targetgroup.Group {
 	})
 
 	group.Labels = prom.LabelSet{
-		"device_name": prom.LabelValue(s.Name),
+		"device_name":   prom.LabelValue(s.Name),
 		"location_name": prom.LabelValue(s.Loc.Name),
-		"status": prom.LabelValue(*s.Status.Value),
+		"status":        prom.LabelValue(*s.Status.Value),
+		"device_type":   prom.LabelValue(s.DeviceType.Slug),
 	}
 
 	return group