Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump prometheus galaxy collection #29

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

thalesmg
Copy link
Contributor

@thalesmg thalesmg commented Oct 1, 2024

So that it supports ansible 2.17.*

prometheus-community/ansible#414

@thalesmg thalesmg marked this pull request as ready for review October 1, 2024 17:58
@thalesmg
Copy link
Contributor Author

thalesmg commented Oct 1, 2024

weird: even bumping the version, still got:

terraform_data.ansible_init (local-exec): Executing: ["/bin/sh" "-c" "ansible-galaxy collection install -r ansible/requirements.yml"]
terraform_data.ansible_init (local-exec): [WARNING]: Collection prometheus.prometheus does not support Ansible version
terraform_data.ansible_init (local-exec): 2.17.4

... but the galaxy collection page claims up to 2.17.99 is supported. 🤔

@id
Copy link
Collaborator

id commented Oct 1, 2024

weird, 0.19.0 was installed without warnings on my machine, ansible 2.17.4

@thalesmg
Copy link
Contributor Author

thalesmg commented Oct 1, 2024

weird, 0.19.0 was installed without warnings on my machine, ansible 2.17.4

strange that 0.16.3 doesn't seem to log either

I tried reinstalling with --force too, didn't get any warnings

only when I did terraform apply ... it printed that 🤔

@thalesmg thalesmg merged commit 2636ffe into emqx:master Oct 1, 2024
@thalesmg thalesmg deleted the bump-prom-galaxy-collection branch October 1, 2024 20:09
@id
Copy link
Collaborator

id commented Oct 2, 2024

May be when terraform executes ansible it resolves it to different package installed by different python? I.e., if you use venv or asdf, terraform probably does not make use of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants