All make platforms should use one instance of shared resources #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@blond take a look please |
j0tunn
force-pushed
the
fix/shared.resources
branch
from
d55a361 to
2a6c669
Compare
| // Используем sharedResources основной make-платформы, если она была проинициализирована | ||
| var sharedResources = baseMakePlatform.getSharedResources(); | ||
| if (sharedResources) { | ||
| makePlatform._sharedResources = sharedResources; |
There was a problem hiding this comment.
А точно не стоит сделать сеттер вместо доступа к приватной переменной?
There was a problem hiding this comment.
здесь не сеттер нужно делать, здесь нужно унести это все в сам enb. Этот код по большому счету - один большой хак, и тут приватные данные уже используются. Сеттер для sharedResources смысла не имеет
j0tunn
force-pushed
the
fix/shared.resources
branch
from
2a6c669 to
a2f8eaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.