Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make logger names configurable #2503

Closed

Conversation

raf-moreau
Copy link

I'm using uvicorn to start, programmaticly, multiple servers.
But logs were always uvicorn.error or uvicorn.access.
I need to make a difference regarding the source server emitting the log.

I added an optional parameter in Config constructor to allow overriding the loggers names.
And i patched the code to use the logger coming from Config instead of using global objects.

So, as an example, adding this parameter
logger_mappings = { "general": "mylogger.general", "access": "mylogger.access", "asgi": "mylogger.asgi", }
to the Config constructor shall configure the logging in the correct loggers.

I did hack a bit the Config object to maintain maximum compatibility with existing code.

PS: If you find my code is ugly, i agree and i'm willing to improve it.
PS2: Forgive my english

@Kludex
Copy link
Member

Kludex commented Nov 20, 2024

Can you please create a discussion?

We do have an issue regarding logger names, but I don't think that's what you expect to change? #562

@Kludex Kludex closed this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants