Add vector3 #340
Merged
Add vector3 #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good start! I can add Block Code to a Node3D and see the Vector3 input of position, rotation, scale. Now when I try to add some numbers for the X, Y, Z I see errors in the output: |
manuq
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
This is working very well now!
Grabación de pantalla desde 2024-12-17 09-03-13.webm
As last thing, could you add some blocks for Vector3 handling? Like these ones for Vector2:
Basically:
- Blocks for obtaining the Vector3 components (x, y, z).
- A block for composing a Vector3 with 3 components.
Then it's good to merge.
manuq
approved these changes
Dec 17, 2024
Vector3 was previously only supported as a getter block, now it also is supported as a setter along with new math blocks and a new vector3 variable block. I made the following changes - adding vector3 to the parameter_input scene - adding vector3 to types.gd - adding vector3 to blocks_catalog.gd and blocks_ast.gd - created new math blocks: vector3_x, vector3_y, vector3_z and vector3_multiply - created new vector3 variable block Fixes endlessm#330
IntegerOverfl0w
force-pushed
the
add_vector3
branch
from
e2e7397 to
5afe404
Compare
|
just squashed the commits, should be ready to merge now. |
|
The blocks for Vector3 operations are working! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/claim #330
I added Vector3 support to parameter_input and blocks_catalog.