-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use subchannel in OpenmcHeatDriver #59
Conversation
@aprilnovak The issues with variable sizes are spread throughout a lot of the project, and I just commented on the parts that you touched in this PR. Some of these might be better addressed elsewhere in the code you didn't touch (for example, I can see some of them being addressed in class declarations that you didn't touch here). If you feel that way, please feel free to ignore my comments on a case-by-case basis. |
Thanks for the detailed review @RonRahaman! I haven't been consistent with using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing this! Look forward to using it.
Thanks for the detailed review @RonRahaman! I've decided to address the narrowing issues here, I'll go after other ones in the project for #61. |
18bdd33
to
6c1bdab
Compare
6c1bdab
to
9ed8bad
Compare
There are some bugs with how the indices are being used to access |
9ed8bad
to
efe285b
Compare
This MR adds use of the subchannel fluid temperature and density solutions in OpenMC for the
OpenmcHeatDriver
. Auxiliary features include:This MR doesn't include any checks on convergence based on density or fluid temperature, which I think should be added as a separate commit. In the design here, I found it easier to work with temperatures and densities for the fluid and solid separately so that not a whole lot of reworking was needed for the existing solid solution. This results in the
fluid_mask
being un-used. I think this is fine for now, but I envision in the future movingfluid_mask
out of the T/H base class and intoNekDriver
, or changing the internals ofSurrogateHeatDriver
to make it necessary to use.This is marked as WIP until !58 is merged because I found the additional cell fissionable checks to be useful in debugging.