Removed OpenmcDriver::index_filter_, replaced with local variable #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This conflicts now that the update to the OpenMC submodule was merged. The idea stands though -- if you want to update to remove the |
|
It's okay now. I came across it when I was working on #61 , but now that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The member
OpenmcDriver::index_filter_is only used inOpenmcDriver::create_tallies(). Every time that member function is called,index_filter_is set from an OpenMC API function. I replaced it with a local variable to make the usage clearer.If anyone wants to use something like
index_filter_later, then they can just query it directly from the OpenMC API, rather than relying on the value from which the member was most-recently set.