Fix resize animations in Dialog #11643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrFlashAccount
requested review from
PabloBuchu,
indiv0,
somebody1234,
Frizi,
farmaazon,
vitvakatu,
kazcw and
AdRiley
as code owners
MrFlashAccount
added
the
CI: No changelog needed
MrFlashAccount
commented
Nov 25, 2024
| @@ -532,42 +520,40 @@ function AppRouter(props: AppRouterProps) { | |||
|
|
|||
| return ( | |||
| <FeatureFlagsProvider> | |||
| <MotionConfig reducedMotion="user" transition={DEFAULT_TRANSITION_OPTIONS}> | |||
There was a problem hiding this comment.
Here we only move the MotionConfig from <App /> to <UIProvider /> to reuse it in Storybook
MrFlashAccount
commented
Nov 25, 2024
| /** | ||
| * Helper hook that uses motion primitive to optimize renders, works best with motion components | ||
| */ | ||
| export function useMeasureSignal(options: Options = {}) { |
There was a problem hiding this comment.
Doesn't work yet with layout prop, see: motiondivision/motion#2907
🧪 Storybook is successfully deployed!📊 Dashboard:
|
MrFlashAccount
commented
Nov 25, 2024
| @@ -116,23 +116,21 @@ export function run(props: DashboardProps) { | |||
| reactDOM.createRoot(root).render( | |||
| <React.StrictMode> | |||
| <QueryClientProvider client={queryClient}> | |||
| <DevtoolsProvider> | |||
There was a problem hiding this comment.
Devtools provider no longer needed due to using the zustand
app/gui/src/dashboard/components/AriaComponents/Dialog/Modal.tsx
Outdated
Show resolved
Hide resolved
MrFlashAccount
added
the
CI: Keep up to date
jdunkerley
removed
the
CI: Keep up to date
MrFlashAccount
force-pushed
the
wip/sergeigarin/fix-dialog-resize-animations
branch
from
a36e5f0 to
264f232
Compare
MrFlashAccount
force-pushed
the
wip/sergeigarin/fix-dialog-resize-animations
branch
from
6611f23 to
0e17420
Compare
MrFlashAccount
added
the
CI: Ready to merge
jdunkerley
pushed a commit
that referenced
this pull request
Nov 29, 2024
This PR fixes the Resize animations in Dialog component: 1. Removes resize for initial mount / fullscreen dialogs 2. Fixes measuring the content size 3. Fixes bugs in `useMeasure` hook 4. Adds memoization for Text and Loader components (because of react-compiler and because this components accept only primitive values) (cherry picked from commit 0c7e79c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR fixes the Resize animations in Dialog component:
useMeasurehookImportant Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.