Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort assets by modified date #11820

Merged
merged 26 commits into from
Dec 24, 2024
Merged

Sort assets by modified date #11820

merged 26 commits into from
Dec 24, 2024

Conversation

MrFlashAccount
Copy link
Contributor

@MrFlashAccount MrFlashAccount commented Dec 10, 2024 •
edited
Loading

Pull Request Description

Closes: https://github.com/enso-org/cloud-v2/issues/1611, https://github.com/enso-org/cloud-v2/issues/1602

This PR refactors the EditableSpan component and improve ergonomics of editing file names.

Now:

  1. It displays loading state
  2. It shows error if something goes wrong
  3. It validates the name
  4. Changed behavior of comparing asset names: now it's case insensitive and compare across all assets

Also, this PR changes the default order of assets in Cloud backend to match the order with the Local one

This PR fixes the tooltip when a project being executed by another user

CleanShot.2024-12-14.at.14.03.01.mp4
CleanShot.2024-12-14.at.14.04.01.mp4

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 10, 2024 •
edited
Loading

🧪 Storybook is successfully deployed!

📊 Dashboard:

@MrFlashAccount MrFlashAccount added CI: No changelog needed Do not require a changelog entry for this PR. g-dashboard labels Dec 12, 2024
@MrFlashAccount MrFlashAccount self-assigned this Dec 12, 2024
@MrFlashAccount
Fix used by another dev behavior
cd30c89
@MrFlashAccount
Merge branch 'develop' into wip/sergeigarin/fix-concurrent-access
b0f14c0 
# Conflicts:
#	app/gui/integration-test/dashboard/actions/api.ts
#	app/gui/integration-test/dashboard/actions/index.ts
#	app/gui/integration-test/dashboard/assetsTableFeatures.spec.ts
#	app/gui/src/dashboard/layouts/AssetsTable.tsx
@MrFlashAccount
Merge branch 'develop' into wip/sergeigarin/fix-concurrent-access
6711ed5
@MrFlashAccount
FIxes
7329bf7
@MrFlashAccount
Remove unused import
ee1c382
@MrFlashAccount MrFlashAccount marked this pull request as ready for review December 13, 2024 21:26
MrFlashAccount
MrFlashAccount commented Dec 13, 2024
View reviewed changes
app/gui/src/dashboard/App.tsx
@@ -519,40 +518,38 @@ function AppRouter(props: AppRouterProps) {
)

return (
<FeatureFlagsProvider>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I only removed the FeatureFlagsProvider

4e6
4e6 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@4e6 4e6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tools part looks good to me

MrFlashAccount
MrFlashAccount commented Dec 16, 2024
View reviewed changes
app/gui/src/dashboard/providers/FeatureFlagsProvider.tsx
) => void
}

const flagsStore = createStore<FeatureFlags>()(
const flagsStore = createStore<FeatureFlagsStore>()(
persist(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@somebody1234 I found that the zustand has native support for persisting state, wdyt?

MrFlashAccount
MrFlashAccount commented Dec 16, 2024
View reviewed changes
app/gui/src/dashboard/providers/TextProvider.tsx
@@ -70,18 +68,12 @@ export default function TextProvider(props: TextProviderProps) {
/** Exposes a property to get localized text, and get and set the current language. */
export function useText() {
const { language, setLanguage, locale } = React.useContext(TextContext)
const localizedText = text.TEXTS[language]

const localizedText = text.getDictionary(language)

const getText = React.useCallback<GetText>(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is pulled off the provider, so we can now use it outside of React.

@PabloBuchu
Copy link
Contributor

PabloBuchu commented Dec 19, 2024 •
edited
Loading

  1. Loader after rename sometimes properly waits till title is updated sometimes it sets the name back to old one and refetch updates to new value
Screen.Recording.2024-12-19.at.09.44.04.mp4
  1. Here you can see the given project is in Opened state but it shows as Closed
Screenshot 2024-12-19 at 09 33 40

@MrFlashAccount
Copy link
Contributor Author

Loader after rename sometimes properly waits till title is updated sometimes it sets the name back to old one and refetch updates to new value

It's the backend issue, we discussed it, it requires a fix on the backend

Here you can see the given project is in Opened state but it shows as Closed

Oh intersting. Will take a look. Guess there are some out of sync state between the listDirectories and the getProjectDetails

@PabloBuchu is it possible though?

@MrFlashAccount MrFlashAccount mentioned this pull request Dec 19, 2024
Merged
5 tasks
MrFlashAccount and others added 4 commits December 19, 2024 18:28
@MrFlashAccount
Fix tests
a0333b0
@JaroslavTulach @MrFlashAccount
Promote broken values instead of ignoring them (#11777)
e7840ca 
Partially fixes #5430 by propagating `DataflowError`s found during statement execution out of the method.

# Important Notes
This change [may affect behavior](https://github.com/enso-org/enso/pull/11673/files#r1871128327) of existing methods that ignore `DataflowError` as [discussed here](https://github.com/enso-org/enso/pull/11673/files#r1871128327).
@jdunkerley @MrFlashAccount
Missed one :( (#11918)
4653eca
@MrFlashAccount
remove console logs
b50ae41
@MrFlashAccount
Copy link
Contributor Author

@PabloBuchu addressed the second issue. Please take a look once you have time 😊

@MrFlashAccount MrFlashAccount merged commit 5777fa6 into develop Dec 24, 2024
40 checks passed
@MrFlashAccount MrFlashAccount deleted the wip/sergeigarin/fix-concurrent-access branch December 24, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabloBuchu PabloBuchu PabloBuchu approved these changes

@4e6 4e6 4e6 approved these changes

@JaroslavTulach JaroslavTulach Awaiting requested review from JaroslavTulach

@radeusgd radeusgd Awaiting requested review from radeusgd

@hubertp hubertp Awaiting requested review from hubertp

@indiv0 indiv0 Awaiting requested review from indiv0 indiv0 is a code owner

@somebody1234 somebody1234 Awaiting requested review from somebody1234 somebody1234 is a code owner

@Frizi Frizi Awaiting requested review from Frizi Frizi is a code owner

@farmaazon farmaazon Awaiting requested review from farmaazon farmaazon is a code owner

@vitvakatu vitvakatu Awaiting requested review from vitvakatu vitvakatu is a code owner

@kazcw kazcw Awaiting requested review from kazcw kazcw is a code owner

@AdRiley AdRiley Awaiting requested review from AdRiley AdRiley is a code owner

@jdunkerley jdunkerley Awaiting requested review from jdunkerley

@GregoryTravis GregoryTravis Awaiting requested review from GregoryTravis

@marthasharkey marthasharkey Awaiting requested review from marthasharkey

@Akirathan Akirathan Awaiting requested review from Akirathan

Assignees

@MrFlashAccount MrFlashAccount

Labels
CI: No changelog needed Do not require a changelog entry for this PR. g-dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MrFlashAccount @PabloBuchu @4e6 @JaroslavTulach @jdunkerley