-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs panel: add support for loading images from the Cloud #11884
Merged
+140
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrFlashAccount
added
g-dashboard
CI: No changelog needed
Do not require a changelog entry for this PR.
labels
Dec 16, 2024
🧪 Storybook is successfully deployed!📊 Dashboard:
|
MrFlashAccount
requested review from
4e6,
JaroslavTulach,
radeusgd,
hubertp,
PabloBuchu,
indiv0,
somebody1234,
Frizi,
farmaazon,
vitvakatu,
kazcw and
AdRiley
as code owners
December 17, 2024 09:46
app/gui/src/dashboard/components/MarkdownViewer/defaultRenderer.ts
Outdated
Show resolved
Hide resolved
somebody1234
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR ✅
4e6
approved these changes
Dec 17, 2024
MrFlashAccount
force-pushed
the
wip/sergeigarin/docs-panel-Images
branch
from
December 19, 2024 14:57
f9d167c
to
550ed7d
Compare
PabloBuchu
approved these changes
Dec 20, 2024
MrFlashAccount
force-pushed
the
wip/sergeigarin/docs-panel-Images
branch
from
December 22, 2024 13:16
550ed7d
to
49fb5a9
Compare
MrFlashAccount
added
the
CI: Ready to merge
This PR is eligible for automatic merge
label
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI: No changelog needed
Do not require a changelog entry for this PR.
CI: Ready to merge
This PR is eligible for automatic merge
g-dashboard
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://github.com/enso-org/cloud-v2/issues/1618
This PR adds support for loading images from the Cloud.