-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Await component #11936
Await component #11936
Conversation
🧪 Storybook is successfully deployed!📊 Dashboard:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR ✅
logic for Await.tsx
looks a little scuffed but it's understandable why it's done that way, and if it works it works...
... although i guess having a global WeakMap
is a little less cursed, although it will require type assertions
What exactly is unclear? Maybe I should provide extra comments to address your questions I agree on using WeakMaps, it's an alternative solution. If you wish I'll reimplement this using WeakMap, I anyway will add some tests before merging it |
@Frizi I bumped the |
Pull Request Description
This PR adds an
<Await />
component, that allows to triggerSuspense
inside the componentImportant Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.