Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate watched files for IDE Packaging CI workflow #11940

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented Dec 24, 2024

Pull Request Description

Changelog:

  • add: separate ide-changed-files.yml workflow tracking the changes in IDE-related files

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@4e6 4e6 added the CI: No changelog needed Do not require a changelog entry for this PR. label Dec 24, 2024
@4e6 4e6 self-assigned this Dec 24, 2024
Copy link

github-actions bot commented Dec 24, 2024

🧪 Storybook is successfully deployed!

📊 Dashboard:

@@ -37,7 +37,6 @@ jobs:
.prettierignore
vitest.workspace.ts
.github/workflows/gui*
.github/workflows/ide*
.github/workflows/storybook.yml
files_ignore: |
app/ide-desktop/**
Copy link
Contributor Author

@4e6 4e6 Dec 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because gui-changed-files.yml ignores the ide-desktop directory, this PR introduces a separate ide-changed-files.yml that watches Electron-related files and triggers the IDE Packaging workflow.

@4e6 4e6 added the CI: Ready to merge This PR is eligible for automatic merge label Dec 27, 2024
@mergify mergify bot merged commit 9cd355c into develop Dec 27, 2024
41 of 42 checks passed
@mergify mergify bot deleted the wip/db/ci-ide-changed-files branch December 27, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants