-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bugs around mass selection/single selection/drag and drop #11942
Open
MrFlashAccount
wants to merge
9
commits into
develop
Choose a base branch
from
wip/sergeigarin/fix-selection-in-assets-table
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix bugs around mass selection/single selection/drag and drop #11942
MrFlashAccount
wants to merge
9
commits into
develop
from
wip/sergeigarin/fix-selection-in-assets-table
+1,275
−348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able # Conflicts: # app/gui/src/dashboard/components/dashboard/AssetRow.tsx
MrFlashAccount
added
CI: No changelog needed
Do not require a changelog entry for this PR.
g-dashboard
labels
Dec 25, 2024
🧪 Storybook is successfully deployed!📊 Dashboard:
|
MrFlashAccount
commented
Dec 26, 2024
const preventSelection = useEventCallback((event: PointerEvent) => { | ||
const { target } = event | ||
|
||
if (target instanceof HTMLElement) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not ideal, but working solution to ignore selection start over selected rows
MrFlashAccount
requested review from
PabloBuchu,
indiv0,
somebody1234,
Frizi,
farmaazon,
vitvakatu,
kazcw and
AdRiley
as code owners
December 26, 2024 16:44
PabloBuchu
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes: https://github.com/enso-org/cloud-v2/issues/1633
This PR:
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.