fix special characters in hyperlink in ag grid #11962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪 Storybook is successfully deployed!📊 Dashboard:
|
marthasharkey
changed the title
marthasharkey
commented
Jan 2, 2025
| @@ -438,10 +442,7 @@ function toLinkField(fieldName: string, options: LinkFieldOptions = {}): ColDef | |||
| params.node?.rowPinned === 'top' ? | |||
| null | |||
| : `Double click to view this ${tooltipValue ?? 'value'} in a separate component`, | |||
| cellRenderer: (params: ICellRendererParams) => | |||
There was a problem hiding this comment.
Removing this as it is no longer needed- the pinned row was the original set up of the data metrics and this has been leftover from that
marthasharkey
requested review from
Frizi,
farmaazon,
vitvakatu,
kazcw and
AdRiley
as code owners
kazcw
approved these changes
Jan 3, 2025
| @@ -197,7 +197,11 @@ function formatText(params: ICellRendererParams) { | |||
| .replaceAll('>', '>') | |||
|
|
|||
| if (textFormatterSelected.value === 'off') { | |||
| return htmlEscaped.replace(/^\s+|\s+$/g, ' ') | |||
| const replaceLinks = htmlEscaped.replace( | |||
| /https?:\/\/([a-zA-Z0-9-]+(\.[a-zA-Z0-9-]+)+)(:[0-9]+)?(\/[-()_.!~*';/?:%@&=+$,A-Za-z0-9]*)?/, | |||
There was a problem hiding this comment.
This regexp could use some test cases. test.each may be helpful. I would test what the RE matches rather than the expected result of inserting the <a> tag so that it is independent of the details of link rendering.
There was a problem hiding this comment.
Actually, we have a LINKABLE_URL_REGEX that might be appropriate here
Comment on lines
225
to
228
| const replaceLinks = replaceSpaces.replace( | ||
| /https?:\/\/([-()_.!~*';/?:@&=+$,A-Za-z0-9])+/g, | ||
| /https?:\/\/([a-zA-Z0-9-]+(\.[a-zA-Z0-9-]+)+)(:[0-9]+)?(\/[-()_.!~*';/?:%@&=+$,A-Za-z0-9]*)?/, | ||
| (url: string) => `<a href="${url}" target="_blank" class="link">${url}</a>`, | ||
| ) |
There was a problem hiding this comment.
This is complex enough to warrant extraction to a function rather than duplicating it.
marthasharkey
added
CI: No changelog needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.