Skip to content

Commit

Permalink
[mob][photos] Use media_kit player for videos not supported by native…
Browse files Browse the repository at this point in the history
… player (#4429)

## Description

On iOS, if a video is unsupported by the native player, the app will
switch automatically to use media_kit player.
On android, user will have to manually switch to the media_kit player.  

I used white with 20% opacity for the icon that switches to the MediaKit
player, making it most noticeable against the darkest background (black,
when the video isn't playable) and less prominent against lighter
backgrounds.



https://github.com/user-attachments/assets/b4316c6e-1691-4328-8984-4d8240179873



Have fixed a UI/UX issue on the video player seen when the video has a
caption/description.
  • Loading branch information
ashilkn authored Dec 18, 2024
2 parents 1fb9a7e + b139dea commit 29052e2
Show file tree
Hide file tree
Showing 79 changed files with 2,890 additions and 2,166 deletions.
3 changes: 3 additions & 0 deletions mobile/lib/events/use_media_kit_for_video.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import "package:photos/events/event.dart";

class UseMediaKitForVideo extends Event {}
2 changes: 2 additions & 0 deletions mobile/lib/generated/intl/messages_ar.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions mobile/lib/generated/intl/messages_be.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion mobile/lib/generated/intl/messages_bg.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion mobile/lib/generated/intl/messages_ca.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion mobile/lib/generated/intl/messages_cs.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions mobile/lib/generated/intl/messages_da.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

323 changes: 197 additions & 126 deletions mobile/lib/generated/intl/messages_de.dart

Large diffs are not rendered by default.

4 changes: 3 additions & 1 deletion mobile/lib/generated/intl/messages_el.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 29052e2

Please sign in to comment.