Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include exporting of shared files on desktop #3319

Merged
merged 6 commits into from
Sep 21, 2024

Conversation

Trekky12
Copy link
Contributor

Description

This PR adds a new switch on the ExportModal to include export of shared files.
This should fix #2322

@ua741
Copy link
Member

ua741 commented Sep 21, 2024

Hey @Trekky12,
Thank you for the PR. For now, we have decided to by default included Shared files in the export. Can you please remove the UI component, and make the required change. :)

@Trekky12 Trekky12 force-pushed the export-shared-files-desktop branch from 31ac1e6 to d1b60b7 Compare September 21, 2024 10:23
@Trekky12
Copy link
Contributor Author

Thank you for your response and the possibility to include my PR 😊. I've adjusted the code and removed the UI components.

@mnvr mnvr merged commit 94a8ff2 into ente-io:main Sep 21, 2024
2 checks passed
mnvr added a commit that referenced this pull request Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants