Dashes in ENV var names not supported by docker compose #4269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker compose no longer supports dashes in ENV var names, hence some vars need to be defined in museum.yml See docker/compose#12302 for details
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was trying to set this up, I was getting errors from
docker compose:There was, apparently, a brief period in time when
docker composesupported dashes in ENV var names, but this is no longer the case, hence some vars need to be defined in amuseum.ymland mounted into the instance. Maybe there is some rewriting in place that allows to redefinemuseum.ymlentries with dashes in ENV vars, however I couldn't find it (and if there isn't, there probably should be, but this change should make the guide usable again at least).