[auth] Add Support for Custom Icons #4395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ua741
reviewed
Dec 13, 2024
auth/lib/ui/utils/icon_utils.dart
Outdated
Comment on lines
219
to
233
| enum IconType { simpleIcon, customIcon } | ||
|
|
||
| class AllIconData { | ||
| final String title; | ||
| final IconType type; | ||
| final String? color; | ||
| final String? slug; | ||
|
|
||
| AllIconData({ | ||
| required this.title, | ||
| required this.type, | ||
| required this.color, | ||
| this.slug, | ||
| }); | ||
| } |
There was a problem hiding this comment.
let's define these types under models?
ua741
reviewed
Dec 13, 2024
auth/lib/models/code_display.dart
Outdated
| @@ -12,6 +13,9 @@ class CodeDisplay { | |||
| String note; | |||
| final List<String> tags; | |||
| int position; | |||
| String customIconData; | |||
| bool isCustomIcon; | |||
| IconType iconType; | |||
There was a problem hiding this comment.
Instead of defining type, let's just use src
String iconSrc;
String iconID;
isCustomIcon can just be a getter => iconSrc != '' && iconID |=''l
ua741
reviewed
Dec 16, 2024
auth/lib/models/code_display.dart
Outdated
| @@ -21,8 +23,12 @@ class CodeDisplay { | |||
| this.tags = const [], | |||
| this.note = '', | |||
| this.position = 0, | |||
| this.iconSrc = 'ente', | |||
There was a problem hiding this comment.
the default value can be empty? Any reason to prefer 'ente' over empty?
There was a problem hiding this comment.
Yes so when add a new code and then go to edit it, there we show 2 icons
- ente icon
- icon based on issuer name
so when there is new code added we need to show some icon for 1. so put ente icon as default, took reference from 2FAS
ua741
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new feature allowing users to select and assign custom icons to their codes.