AWS S3 blob storage #325
Merged
AWS S3 blob storage #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testower
reviewed
May 29, 2024
testower
reviewed
May 29, 2024
src/ext/java/no/entur/uttu/ext/fintraffic/export/blob/S3BlobStoreRepository.java
Outdated
Show resolved
Hide resolved
testower
reviewed
May 29, 2024
I think it's a very interesting option! |
testower
reviewed
May 31, 2024
testower
approved these changes
May 31, 2024
vpaturet
reviewed
May 31, 2024
src/main/java/no/entur/uttu/export/blob/LocalDiskBlobStoreRepositoryConfig.java
Outdated
Show resolved
Hide resolved
…rrent behavior We discussed this with @testower elsewhere and agreed this should be the approach for now
vpaturet
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker run...withdocker-compose.ymlThere are some potentially breaking or at least confusing-to-user changes to how profiles are handled, plus the documentation is slightly confusing now since both the Docker Compose has optional profiles and the service itself uses profiles in a way where specific combinations of profiles are intended to work together.
As further thought, having the Google PubSub Emulator available as Docker Compose profile similar to LocalStack might also be a rather clean way to do that as well.