New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document how to prevent faulty activation of s3 autoconfiguration #336

Merged

testower merged 1 commit into entur:master from esuomi:update_s3_documentation

Jun 6, 2024

Collaborator

esuomi commented Jun 6, 2024

the AWSpring project is a bit weird, the reason S3 autoconfiguration was enabled is because

spring-cloud-aws-starter-secrets-manager depends on spring-cloud-aws-starter
spring-cloud-aws-starter depends on spring-cloud-aws-autoconfigure

and in spring-cloud-aws-autoconfigure exists S3AutoConfiguration.java with

@ConditionalOnClass({ S3Client.class, S3OutputStreamProvider.class })  // these are in classpath because we have manual S3 integration
@ConditionalOnProperty(name = "spring.cloud.aws.s3.enabled", havingValue = "true", matchIfMissing = true)

This might be worth filing an issue to AWSpring if one doesn't already exist, although I wouldn't hold my breath on this getting fixed on their side.


          document how to prevent faulty activation of s3 autoconfiguration

95743a7

testower merged commit 44610e2 into entur:master

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet