Revert "Install Java 8, Android command line tools and SDK for Ubuntu" #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm, but needs DCO |
…envoyproxy#188)" This reverts commit dce0a8c. Signed-off-by: JP Simard <[email protected]>
jpsim
force-pushed
the
revert-188-install-android-command-line-tools-and-sdk-for-ubuntu
branch
from
1ae9b66 to
0ca6559
Compare
I created the revert using GitHub's UI. Is there a way to configure it to apply signoff when that's used? Or is it necessary to sign off locally? |
|
not sure if there is a way to get gh to do it - i dont use it for that reason - i think you have to sign it off locally |
phlax
approved these changes
Dec 9, 2022
|
FYI I don't have merge access on this repo. |
jpsim
deleted the
revert-188-install-android-command-line-tools-and-sdk-for-ubuntu
branch
htuch
pushed a commit
that referenced
this pull request
Dec 9, 2022
[skip ci] Revert "Install Java 8, Android command line tools and SDK for Ubuntu" (#189) This reverts commit dce0a8c. Signed-off-by: JP Simard <[email protected]>
htuch
pushed a commit
that referenced
this pull request
Dec 9, 2022
[skip ci] Regenerate linux toolchains from 5c8e6ab [skip ci] Revert "Install Java 8, Android command line tools and SDK for Ubuntu" (#189) This reverts commit dce0a8c. Signed-off-by: JP Simard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #188
This grew the Docker image by an unreasonable amount, going from 1.79 GB to 3.77 GB.