android: put cronet files into final EM aar #2481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rafal Augustyniak <[email protected]>
|
@RyanTheOptimist without importing cronet somewhere in BUILD files this fails - can you cherry-pick this change into your PR instead? |
Sure! I've added this into my PR #2423. |
|
Closing the PR as the change introduced in here was merged as part of #2423 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Change the script so that cronet files end up being a part of Envoy Mobile aar. Needed for #2432.
Risk Level: Low, the change should be additive.
Testing: Manual testing
Docs Changes: N/A
Release Notes: N/A
Signed-off-by: Rafal Augustyniak [email protected]