Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eventually fixing cleartext code #2488

Closed
wants to merge 2 commits into from

Conversation

alyssawilk
Copy link
Contributor

Signed-off-by: Alyssa Wilk [email protected]

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]

Signed-off-by: Alyssa Wilk <[email protected]>
@Augustyniak
Copy link
Contributor

@alyssawilk just FYI: as they are now, Robolectric tests are not enough to test the implementation of is_cleartext_permitted since the #if defined(__ANDROID_API__) that's a part of the implementation of that method evaluates to false in Roboelectric tests. For #if defined(__ANDROID_API__) to evaluate to true we need to build EM with Android tool chain and run the app on the actual emulator - that's something that we are working on as part of #2450.

@alyssawilk alyssawilk closed this Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants