Add a setPerTryIdleTimeoutSeconds method to EngineBuilder. #2601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests for setPerTryIdleTimeoutSeconds and setStreamIdleTimeoutSeconds. Minor cleanup of envoy_config_test.cc. Signed-off-by: Ryan Hamilton <[email protected]>
RyanTheOptimist
force-pushed
the
ConfigTest
branch
from
f7ec2e1 to
0bf7be7
Compare
|
/assign @Augustyniak |
Augustyniak
reviewed
Oct 11, 2022
| @@ -38,6 +38,7 @@ class EngineBuilder { | |||
| EngineBuilder& setAppId(const std::string& app_id); | |||
| EngineBuilder& setDeviceOs(const std::string& app_id); | |||
| EngineBuilder& setStreamIdleTimeoutSeconds(int stream_idle_timeout_seconds); | |||
| EngineBuilder& setPerTryIdleTimeoutSeconds(int per_try_idle_timeout_seconds); | |||
There was a problem hiding this comment.
our Kotlin and Swift engines use add... naming but the c++ seems to prefer set... one... I guess it's fine to keep using set in here (which I personally prefer)
Signed-off-by: Ryan Hamilton <[email protected]>
Whoops! Done. |
jpsim
added a commit
that referenced
this pull request
Oct 11, 2022
* origin/main: Update Envoy (#2598) Add a setPerTryIdleTimeoutSeconds method to EngineBuilder. (#2601) Signed-off-by: JP Simard <[email protected]>
colibie
pushed a commit
to colibie/envoy-mobile
that referenced
this pull request
Oct 22, 2022
…y#2601) Add a setPerTryIdleTimeoutSeconds method to EngineBuilder. Add tests for setPerTryIdleTimeoutSeconds and setStreamIdleTimeoutSeconds. Minor cleanup of envoy_config_test.cc. Part of envoyproxy#2498 Risk Level: Low Testing: Added unit tests Docs Changes: N/A Release Notes: Updated version_history.txt Signed-off-by: Ryan Hamilton <[email protected]> Signed-off-by: Chidera Olibie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a setPerTryIdleTimeoutSeconds method to EngineBuilder.
Add tests for setPerTryIdleTimeoutSeconds and setStreamIdleTimeoutSeconds.
Minor cleanup of envoy_config_test.cc.
Part of #2498
Risk Level: Low
Testing: Added unit tests
Docs Changes: N/A
Release Notes: Updated version_history.txt