Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: android ci on linux #91

Merged
merged 14 commits into from
Jun 17, 2019
Merged

ci: android ci on linux #91

merged 14 commits into from
Jun 17, 2019

Conversation

junr03
Copy link
Member

@junr03 junr03 commented Jun 14, 2019

Signed-off-by: Jose Nino [email protected]

Description: setup android CI on linux.
Risk Level: low
Testing: adding CI

Part of #42

@junr03 junr03 force-pushed the android-linux-ci branch from c1545c9 to 15a1f30 Compare June 15, 2019 14:03
Signed-off-by: Jose Nino <[email protected]>
@junr03 junr03 force-pushed the android-linux-ci branch from 15a1f30 to c7fa933 Compare June 15, 2019 14:05
@@ -29,6 +29,72 @@ jobs:
submodules: true
- script: swiftlint lint --strict
displayName: 'Run SwiftLint'
- job: android_dist
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will homogenize and stage all the jobs in a subsequent PR.

@@ -0,0 +1,26 @@
#!/bin/bash
Copy link
Member Author

@junr03 junr03 Jun 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now I install the envoy build dependencies on the Azure host because the azure hosts have a functional SDK and NDK toolchain. As well as emulators for a potential CI job that runs the app. I will work on containerizing this in a subsequent PR to save the ~1.5mins that this takes on a job.

Jose Nino added 4 commits June 15, 2019 07:32
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
@junr03 junr03 requested review from rebello95 and goaway June 16, 2019 16:34
azure-pipelines.yml Outdated Show resolved Hide resolved
Co-Authored-By: Alan Chiu <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
@junr03 junr03 force-pushed the android-linux-ci branch from 6d2655c to 2d848ad Compare June 16, 2019 21:09
buildbreaker
buildbreaker previously approved these changes Jun 17, 2019
Copy link

@buildbreaker buildbreaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with how much work your "todos" comments are but would they warrant creating an issue for?

Copy link
Contributor

@rebello95 rebello95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Some comments - great that this is working.

azure-pipelines.yml Outdated Show resolved Hide resolved
azure-pipelines.yml Show resolved Hide resolved
azure-pipelines.yml Outdated Show resolved Hide resolved
azure-pipelines.yml Show resolved Hide resolved
steps:
- checkout: self
submodules: true
- script: ./ci/linux_ci_setup.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this since dependsOn: android_dist is specified above?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know, I have not experimented with this. i.e I am not sure if the jobs are run on on the same job agent. I would bet not. I would believe that each job is hermetic w.r.t other jobs regardless of the dependency graph. In truth what should be done here is that all the linux deps should be contaneirized. I was having trouble with that and protobuf for some reason. I can look into minimizing dep install this week.

#100

azure-pipelines.yml Show resolved Hide resolved
azure-pipelines.yml Show resolved Hide resolved
azure-pipelines.yml Outdated Show resolved Hide resolved
ci/linux_ci_setup.sh Outdated Show resolved Hide resolved
ci/linux_ci_setup.sh Outdated Show resolved Hide resolved
Signed-off-by: Jose Nino <[email protected]>
@junr03
Copy link
Member Author

junr03 commented Jun 17, 2019

I'm not too familiar with how much work your "todos" comments are but would they warrant creating an issue for?

@buildbreaker I am doing a TODO pass this morning. Will create issues for any outstanding TODOs we are not doing before release.

@junr03
Copy link
Member Author

junr03 commented Jun 17, 2019

I can't tell if my last comment actually broke the foreign cc rules. I don't see how it could have. Testing with a revert commit.

Signed-off-by: Jose Nino <[email protected]>
Jose Nino added 6 commits June 17, 2019 12:25
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
Copy link
Contributor

@rebello95 rebello95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

@junr03 junr03 merged commit 83697f5 into master Jun 17, 2019
@junr03 junr03 deleted the android-linux-ci branch June 17, 2019 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants