-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: android ci on linux #91
Conversation
Signed-off-by: Jose Nino <[email protected]>
@@ -29,6 +29,72 @@ jobs: | |||
submodules: true | |||
- script: swiftlint lint --strict | |||
displayName: 'Run SwiftLint' | |||
- job: android_dist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will homogenize and stage all the jobs in a subsequent PR.
@@ -0,0 +1,26 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now I install the envoy build dependencies on the Azure host because the azure hosts have a functional SDK and NDK toolchain. As well as emulators for a potential CI job that runs the app. I will work on containerizing this in a subsequent PR to save the ~1.5mins that this takes on a job.
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
Co-Authored-By: Alan Chiu <[email protected]> Signed-off-by: Jose Nino <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not too familiar with how much work your "todos" comments are but would they warrant creating an issue for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Some comments - great that this is working.
steps: | ||
- checkout: self | ||
submodules: true | ||
- script: ./ci/linux_ci_setup.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this since dependsOn: android_dist
is specified above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You know, I have not experimented with this. i.e I am not sure if the jobs are run on on the same job agent. I would bet not. I would believe that each job is hermetic w.r.t other jobs regardless of the dependency graph. In truth what should be done here is that all the linux deps should be contaneirized. I was having trouble with that and protobuf for some reason. I can look into minimizing dep install this week.
Signed-off-by: Jose Nino <[email protected]>
@buildbreaker I am doing a TODO pass this morning. Will create issues for any outstanding TODOs we are not doing before release. |
I can't tell if my last comment actually broke the foreign cc rules. I don't see how it could have. Testing with a revert commit. |
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work
Signed-off-by: Jose Nino [email protected]
Description: setup android CI on linux.
Risk Level: low
Testing: adding CI
Part of #42