Skip to content

Commit

Permalink
ci: update codespell to v2.1.0 (#2406)
Browse files Browse the repository at this point in the history
Description: Update codespell to v2.1.0 due to an issue that surfaced in envoyproxy/envoy-mobile#2400 : `/usr/local/Cellar/[email protected]/3.10.5/Frameworks/Python.framework/Versions/3.10/lib/python3.10/codecs.py:905: RuntimeWarning: line buffering (buffering=1) isn't supported in binary mode, the default buffer size will be used
  file = builtins.open(filename, mode, buffering)`. According to codespell-project/codespell#1331 the update is what fixes it.
Risk Level: Low, linting change only
Testing: N/A
Docs Changes: N/A
Release Notes: Done

Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: JP Simard <[email protected]>
  • Loading branch information
Augustyniak authored and jpsim committed Nov 29, 2022
1 parent 9640e5f commit b32ae2c
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 7 deletions.
4 changes: 2 additions & 2 deletions mobile/.pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ repos:
exclude: 'experimental/swift/QUICStreamTest.swift'
- id: mixed-line-ending
- repo: https://github.com/codespell-project/codespell
rev: v1.16.0
rev: v2.1.0
hooks:
- id: codespell
args: [-L=uint, -L=keyserver]
args: [-L=uint, '-L=keyserver,inout']
2 changes: 1 addition & 1 deletion mobile/docs/root/api/stats.rst
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ The count argument of ``increment`` is defaulted with a value of ``1``.
// Swift
counter.increment(count: 5)

A ``Counter`` can be incremented with custom tags. To be concise, this doc shows examples of attching custom tagging for ``Counter`` on increment. Similar APIs are available for all metrics types to attach tags on metrics reporting.
A ``Counter`` can be incremented with custom tags. To be concise, this doc shows examples of attaching custom tagging for ``Counter`` on increment. Similar APIs are available for all metrics types to attach tags on metrics reporting.

**Example**::

Expand Down
7 changes: 4 additions & 3 deletions mobile/library/java/org/chromium/net/CronetEngine.java
Original file line number Diff line number Diff line change
Expand Up @@ -260,9 +260,10 @@ public Builder addPublicKeyPins(String hostName, Set<byte[]> pinsSha256,
* for local trust anchors is highly discouraged since it may prohibit the app from
* communicating with the pinned hosts. E.g., a user may want to send all traffic through an SSL
* enabled proxy by changing the device proxy settings and adding the proxy certificate to the
* list of local trust anchor. Disabling the bypass will most likly prevent the app from sending
* any traffic to the pinned hosts. For more information see 'How does key pinning interact with
* local proxies and filters?' at https://www.chromium.org/Home/chromium-security/security-faq
* list of local trust anchor. Disabling the bypass will most likely prevent the app from
* sending any traffic to the pinned hosts. For more information see 'How does key pinning
* interact with local proxies and filters?' at
* https://www.chromium.org/Home/chromium-security/security-faq
*
* @param value {@code true} to enable the bypass, {@code false} to disable.
* @return the builder to facilitate chaining.
Expand Down
2 changes: 1 addition & 1 deletion mobile/test/python/unit/test_pre_build_engine.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# This module can't be tested normally
# becuse it needs the Engine not to exist in the process
# because it needs the Engine not to exist in the process
# so each of the tests here are marked to be run
# only in a particular instance of the test runner
# and targets are specified in //library/python/...
Expand Down

0 comments on commit b32ae2c

Please sign in to comment.