Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable joblib.Parallel memory mapping #262

Merged
merged 2 commits into from
Dec 30, 2024
Merged

fix: enable joblib.Parallel memory mapping #262

merged 2 commits into from
Dec 30, 2024

Conversation

eonu
Copy link
Owner

@eonu eonu commented Dec 30, 2024

Enable joblib.Parallel memory mapping

  • Enable memmapping by removing max_nbytes=None.
  • Change mmap_mode="r" to mmap_mode="r+" to fix buffer error.

Checklist

  • I have added new tests (if necessary).
  • I have ensured that tests and coverage are passing on CI.
  • I have updated any relevant documentation (if necessary).
  • I have used a descriptive pull request title.

@eonu eonu merged commit 6366e97 into dev Dec 30, 2024
10 checks passed
@eonu eonu deleted the enable_memmap branch December 30, 2024 12:44
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7052dcbb-7353-4690-aba4-4de903e61b3c

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.59%
Totals Coverage Status
Change from base Build c7acf5ec-3f22-409b-94b8-6f3066c03ed8: 0.0%
Covered Lines: 1167
Relevant Lines: 1413
💛 - Coveralls

@github-actions github-actions bot mentioned this pull request Dec 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eonu @coveralls