#1303 Return original format #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial commit.
Fix indigo service v2
Add new options input-format and output-content-type
Fix formating
Fix indentation
Fix ex=rror in indigo-ketcher.cpp
AlexanderSavelyev
requested changes
Oct 10, 2023
Fix smiles_saver.cpp Forr cycles sequence length may be greater than atoms count
Revert files commeted by mistake
Add UTs Add code according to comments
Fix UT
Fix UTs
AlexanderSavelyev
requested changes
Oct 12, 2023
| ) | ||
|
|
||
|
|
||
| print("****** Test get original format: smiles ***") |
There was a problem hiding this comment.
add test for reaction smiles and smarts
| @@ -486,8 +486,35 @@ M END | |||
| options.delete(); | |||
| }); | |||
|
|
|||
| test("convert", "output-content-type", () => { | |||
There was a problem hiding this comment.
add test for reaction smiles and smarts
AlexanderSavelyev
approved these changes
Oct 12, 2023
|
PR can merged - but all the reactions do not work. Need to create a new ticket to fix it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add code to return original format and support two new options - "input-format" and "output-content-type"