Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: fix timeout error when running .layout #790

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP: fix timeout error when running .layout #790

wants to merge 1 commit into from

Conversation

khyurri
Copy link
Collaborator

@khyurri khyurri commented Jul 19, 2022

This PR fixes #724

@khyurri khyurri requested a review from mkviatkovskii July 19, 2022 14:53
@khyurri khyurri changed the title fix timeout error when running .layout WIP: fix timeout error when running .layout Jul 19, 2022
@khyurri
Copy link
Collaborator Author

khyurri commented Jul 19, 2022

throw Error("Layout chooser has been cancelled: %s", cancellation->cancelledRequestMessage()); causes segmentation fault, need to investigation

@khyurri khyurri changed the title WIP: fix timeout error when running .layout fix timeout error when running .layout Jul 20, 2022
@khyurri khyurri changed the title fix timeout error when running .layout WIP: fix timeout error when running .layout Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkviatkovskii mkviatkovskii Awaiting requested review from mkviatkovskii

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.layout() call runs "forever" even if timeout is specified
1 participant
@khyurri