Make simplestValue top-level for overrides + hasInstance fix on ADTType #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samarion
reviewed
May 11, 2021
| } | ||
| } else { | ||
| val cons = sort.constructors.sortBy(_.fields.size).head | ||
| ADT(cons.id, cons.tps, cons.fields.map(vd => simplestValue(vd.getType, seen + adt, allowSolver))) |
There was a problem hiding this comment.
Actually, the "correct" implementation of simplestValue should probably use streams where all ADT constructors are considered.
…x non-termination in hasInstance
samarion
reviewed
May 11, 2021
|
Not super important, but might make sense to split the tuple fix into a second PR. Did you check that it fixes the issue on the Stainless side? |
Yes and I encountered #153 on the same example, I think this means it was OK for the tuples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.