Add missing globals dictionary to schema #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marcelldls please can you remind me why location and ioc_group are in globals? |
|
@gilesknap I believe it is because we use location and ioc_group across multiple different charts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the
globalsdictionary, this still allowsadditionalPropertiesto be added - which means that you could accidentally include "enable" rather than "enabled" for example. However, since globals are passed to subcharts - there may be legitimate arbitrary globals passed that we have not considered. Im open to adding"additionalProperties": falsebecause it would give a better hint during validation, but opting out of CI would be needed for adding arbitrary globals