Move p46 to new standard of prefixing non-IOC services with the beamline short name #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiamondJoseph
requested review from
ZohebShaikh,
gilesknap and
marcelldls
and removed request for
ZohebShaikh and
gilesknap
|
This looks all good. I approve you moving the targetRevision to individual IOCs. services-template-helm currently encourages the use of a global targetRevision but I think that is counter to controls recommendations for IOCs so we should probably fix that. |
gilesknap
approved these changes
Dec 17, 2024
marcelldls
approved these changes
Dec 19, 2024
ZohebShaikh
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent accidental changes to services when the wrong cluster/namespace are in the Kubernetes context, we will move to naming non-IOC services starting with the beamline short name (e.g. ixx) and IOCs with the beamline long name (e.g. BLXXI)
Requires orchestration of the merge with epics-containers/p46-services#3