Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-17359: Resolve recursive option (-r) failure (eg: in 'zk cp -r' and 'zk rm -r') #8

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

rahulgoswami
Copy link

https://issues.apache.org/jira/browse/SOLR-SOLR-17359

Description

Commands with -r option (eg: zk cp -r or zk rm -r) would fail to operate on directories since the corresponding Zk*Tool.java expects a boolean value for "recursive" option, but instead gets the directory path. This results in errors of nature "ERROR: Index 0 out of bounds for length 0"

Solution

Please provide a short description of the approach taken to implement your solution.

Tests

Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

@epugh epugh merged commit 278c9c9 into epugh:SOLR-17359 Aug 8, 2024
1 check passed
@epugh
Copy link
Owner

epugh commented Aug 8, 2024

I added a BATS test, and it failed... Merged the PR, and it passes! Thanks...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants