-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use release-please #280
base: develop
Are you sure you want to change the base?
ci: use release-please #280
Conversation
@sebhoerl more details about what I say here
I think it can be useful, seeing that the default commit title and body are defined as
In my day to day uses, I always remove the list of commits that compose the merged branch, because they can be internal fixes of the branch, etc. And I fear that with the automatic changelog generation will include this body, and then make things a little messy. But this is only Quality-Of-Life for people that merge the branches, and maybe you want to keep all options available. Up to you to decide if its relevant or not. |
I see in the changelog that we use the version without the preceeding "v". Should this PR be the occasion to remove it from the version number ? |
Fine with me |
I changed the version number to "1.2.0". I think the PR is quite ready, we just need this part that I cannot do:
|
I started using release please in Starling, you can see what the PR looks like here |
PR contents
Release Please
Presentation and usage
Release Please will create and update a release PR when the develop branch receives pushes. When we are ready to release, simply merge the PR.
Commits on the develop branch have to follow the conventional commit convention. This can be done by squash-merging the PRs (highly recommended) and having the title in conventional commit style (hence the action that checks the PRs' titles). We can force the squash-merging and also modify the commit message in the settings, see here. Commits on the working branch don't have to be conventional commits.
Release Please config
See here for the config options of Release Please.
release-type
:simple
(a repository with a version.txt and a CHANGELOG.md)versioning strategy:
default
(breaking changes bump the major version, features bump the minor version, bugfixes bump the patch version)TODO
EQASIM_PAT
.Closes #276
Closes #188