Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify inspection controller #1898

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Simplify inspection controller #1898

wants to merge 2 commits into from

Conversation

tsundvoll
Copy link
Contributor

@tsundvoll tsundvoll commented Dec 18, 2024 •
edited
Loading

by moving more functionality to the inspection service and avoiding a call to the Flotilla database
by using the ISAR Inspection ID directly from the frontend to make the call to the IDA API

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@tsundvoll tsundvoll added backend Backend related functionality improvement Improvement to existing functionality Northern Lights labels Dec 18, 2024
@tsundvoll tsundvoll force-pushed the simplify-inspection-service branch 3 times, most recently from 30a34ae to cc447fa Compare December 18, 2024 12:39
@tsundvoll tsundvoll requested a review from Christdej December 18, 2024 12:40
@tsundvoll
Copy link
Contributor Author

We need to implement the corresponding changes on the frontend before we take in this

@github-actions GitHub Actions
Copy link

🔔 Changes in database folder detected 🔔
Do these changes require adding new migrations? 🤔 In that case follow these steps.
If you are uncertain, ask a database admin on the team 😄

@tsundvoll
Simplify inspection controller
84ccdb5 
by moving more functionality to the inspection service
and avoiding a call to the Flotilla database
by using the ISAR Inspection ID directly from the frontend
to make the call to the IDA API
@tsundvoll
wip use isarInspectionId instead of isarTaskId in frontend
90abced
@tsundvoll tsundvoll force-pushed the simplify-inspection-service branch from 5adc78a to 90abced Compare December 19, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oysand oysand oysand left review comments

@andchiind andchiind andchiind left review comments

@Christdej Christdej Awaiting requested review from Christdej

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
backend Backend related functionality improvement Improvement to existing functionality Northern Lights
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tsundvoll @andchiind @oysand