fix: fix gittar oom

erda-project · Feb 28, 2024 · e3415b6 · e3415b6
1 parent a89edd2
commit e3415b6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/internal/tools/gittar/ai/cr/impl/cr_mr/mr.go b/internal/tools/gittar/ai/cr/impl/cr_mr/mr.go
@@ -76,8 +76,8 @@ func (r *mrReviewer) CodeReview(i18n i18n.Translator, lang i18n.LanguageCodes, a
 	wg := limit_sync_group.NewSemaphore(MaxDiffFileNum) // parallel is 5
 	var mu sync.Mutex
 
-	wg.Add(len(changedFiles))
 	for _, file := range changedFiles {
+		wg.Add(1)
 		fileOrder = append(fileOrder, file.GetFileName())
 		go func(file models.FileCodeReviewer) {
 			defer wg.Done()

diff --git a/pkg/limit_sync_group/group.go b/pkg/limit_sync_group/group.go
@@ -31,11 +31,9 @@ func NewSemaphore(maxSize int) *limitSyncGroup {
 }
 func (s *limitSyncGroup) Add(delta int) {
 	s.wg.Add(delta)
-	go func() {
-		for i := 0; i < delta; i++ {
-			s.c <- struct{}{}
-		}
-	}()
+	for i := 0; i < delta; i++ {
+		s.c <- struct{}{}
+	}
 }
 func (s *limitSyncGroup) Done() {
 	<-s.c