Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dop): issue excel title support i18n #6085

Merged
merged 7 commits into from
Oct 10, 2023

Conversation

sfwn
Copy link
Member

@sfwn sfwn commented Oct 10, 2023

What this PR does / why we need it:

issue excel title support i18n

Specified Reviewers:

/assign @chengjoey

ChangeLog

Language Changelog
🇺🇸 English issue excel title support i18n
🇨🇳 中文 事项 Excel 标题支持国际化

@erda-bot erda-bot added dop devops plaoform feature labels Oct 10, 2023
@erda-bot erda-bot requested a review from chengjoey October 10, 2023 06:55
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #6085 (9c9b684) into master (1daee6a) will decrease coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is 9.43%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6085      +/-   ##
==========================================
- Coverage   22.84%   22.84%   -0.01%     
==========================================
  Files        1769     1771       +2     
  Lines      190624   190653      +29     
==========================================
+ Hits        43547    43553       +6     
- Misses     142081   142106      +25     
+ Partials     4996     4994       -2     
Files Coverage Δ
internal/apps/dop/initialize.go 41.21% <100.00%> (+0.08%) ⬆️
...y/issueexcel/sheets/sheet_issue/export_template.go 0.00% <ø> (ø)
...providers/issue/core/query/issueexcel/vars/data.go 0.00% <ø> (ø)
...core/query/issueexcel/sheets/sheet_issue/export.go 74.00% <75.00%> (-0.18%) ⬇️
internal/apps/dop/providers/issue/core/service.go 8.54% <0.00%> (-0.04%) ⬇️
internal/apps/dop/providers/issue/core/provider.go 13.55% <0.00%> (-0.36%) ⬇️
internal/apps/dop/providers/issue/core/file.go 15.63% <0.00%> (+0.17%) ⬆️
...query/issueexcel/sheets/sheet_issue/import_vars.go 36.76% <0.00%> (-1.70%) ⬇️
.../core/query/issueexcel/sheets/sheet_issue/field.go 0.00% <0.00%> (ø)
...providers/issue/core/query/issueexcel/vars/i18n.go 0.00% <0.00%> (ø)
... and 2 more

... and 6 files with indirect coverage changes

@sfwn sfwn merged commit cb27bb8 into erda-project:master Oct 10, 2023
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dop devops plaoform feature
Development

Successfully merging this pull request may close these issues.

3 participants