refactor: Isolate func and model #6106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6106 +/- ##
=======================================
Coverage 23.00% 23.01%
=======================================
Files 1777 1778 +1
Lines 190821 190916 +95
=======================================
+ Hits 43899 43937 +38
- Misses 141894 141951 +57
Partials 5028 5028
|
jing-zhi
force-pushed
the
feat
branch
3 times, most recently
from
3bf1e3e to
b00b0d3
Compare
chengjoey
reviewed
Oct 25, 2023
Comment on lines
26
to
32
| // batchOperationTipModal: { | ||
| // type: 'Modal', | ||
| // props: { | ||
| // status: 'warning', | ||
| // content: '您将解冻以下节点：\n cn-hongkong.172.15.3.3 \ncn-hongkong.172.15.3.3', | ||
| // title: '提示', | ||
| // }, |
There was a problem hiding this comment.
thank you for pointing out
chengjoey
reviewed
Oct 25, 2023
| @@ -126,6 +126,9 @@ func (p *provider) queryPersonalEfficiency(rw http.ResponseWriter, r *http.Reque | |||
| } | |||
|
|
|||
| rawSql := p.makeEfficiencyBasicSql(req) | |||
| fmt.Println("————————————————————————————打印sql————————————————————————————") | |||
There was a problem hiding this comment.
thank you for pointing out
chengjoey
reviewed
Oct 26, 2023
| } | ||
|
|
||
| // Transfer transfer a to b with json, kind of b must be pointer | ||
| func Transfer(a, b interface{}) error { |
There was a problem hiding this comment.
Transfer is necessary to add unit-test
There was a problem hiding this comment.
thank you for pointing out
feat:add confirmation button for batch deletion
chengjoey
approved these changes
Oct 27, 2023
|
/approve |
erda-bot
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat:add confirmation button for batch deletion
What this PR does / why we need it:
refactor: Isolate func and model
feat:add confirmation button for batch deletion
Which issue(s) this PR fixes:
Specified Reviewers:
/assign @chengjoey @sfwn
ChangeLog
Need cherry-pick to release versions?
Add comment like
/cherry-pick release/1.0when this PR is merged.