-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add license agent openapi proxy #6147
Conversation
0e7c41c
to
eb197ba
Compare
6dc5096
to
e959a21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package license_agent | ||
|
||
import ( | ||
"github.com/erda-project/erda/internal/core/openapi/legacy/api/apis" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please modify the Go import order for all Go files.
@@ -0,0 +1,17 @@ | |||
package license_agent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please identify the license for the project.
go.sum
Outdated
@@ -38,6 +38,8 @@ cloud.google.com/go v0.100.2/go.mod h1:4Xra9TjzAeYHrl5+oeLlzbM2k3mjVhZh4UqTZ//w9 | |||
cloud.google.com/go v0.102.0/go.mod h1:oWcCzKlqJ5zgHQt9YsaeTY9KzIvjyy0ArmiBUgpQ+nc= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you did not change the go.mod file, please avoid committing the go.sum content.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6147 +/- ##
==========================================
- Coverage 22.84% 22.61% -0.23%
==========================================
Files 1804 1830 +26
Lines 193048 195925 +2877
==========================================
+ Hits 44096 44308 +212
- Misses 143912 146556 +2644
- Partials 5040 5061 +21 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @sfwn
@@ -0,0 +1,11 @@ | |||
CREATE TABLE erda_licenses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use singular format for table name: erda_license
) | ||
|
||
var AGENT_LICENSE_FEATURE_GET = apis.ApiSpec{ | ||
Path: "/api/licenses/features", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strange path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve |
What this PR does / why we need it:
add license-agent openapi proxy
Which issue(s) this PR fixes:
Specified Reviewers:
/assign @iutx @sfwn
ChangeLog
Need cherry-pick to release versions?
Add comment like
/cherry-pick release/1.0
when this PR is merged.