Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add license agent openapi proxy #6147

Merged
merged 8 commits into from
Dec 28, 2023

Conversation

CeerDecy
Copy link
Member

What this PR does / why we need it:

add license-agent openapi proxy

Which issue(s) this PR fixes:

  • Fixes #your-issue_number
  • [Erda Cloud Issue Link](paste your link here)

Specified Reviewers:

/assign @iutx @sfwn

ChangeLog

Language Changelog
🇺🇸 English add license agent openapi proxy
🇨🇳 中文 添加了对license-agent的openapi转发

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot erda-bot requested review from iutx and sfwn November 22, 2023 08:36
Copy link
Member

@iutx iutx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package license_agent

import (
"github.com/erda-project/erda/internal/core/openapi/legacy/api/apis"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please modify the Go import order for all Go files.

@@ -0,0 +1,17 @@
package license_agent
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please identify the license for the project.

go.sum Outdated
@@ -38,6 +38,8 @@ cloud.google.com/go v0.100.2/go.mod h1:4Xra9TjzAeYHrl5+oeLlzbM2k3mjVhZh4UqTZ//w9
cloud.google.com/go v0.102.0/go.mod h1:oWcCzKlqJ5zgHQt9YsaeTY9KzIvjyy0ArmiBUgpQ+nc=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you did not change the go.mod file, please avoid committing the go.sum content.

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d4ba245) 22.84% compared to head (7edd63b) 22.61%.
Report is 21 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6147      +/-   ##
==========================================
- Coverage   22.84%   22.61%   -0.23%     
==========================================
  Files        1804     1830      +26     
  Lines      193048   195925    +2877     
==========================================
+ Hits        44096    44308     +212     
- Misses     143912   146556    +2644     
- Partials     5040     5061      +21     

see 60 files with indirect coverage changes

Copy link

stale bot commented Dec 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 15, 2023
@stale stale bot removed the wontfix label Dec 18, 2023
@CeerDecy CeerDecy marked this pull request as ready for review December 28, 2023 02:34
Copy link
Member

@iutx iutx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @sfwn

@@ -0,0 +1,11 @@
CREATE TABLE erda_licenses
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use singular format for table name: erda_license

)

var AGENT_LICENSE_FEATURE_GET = apis.ApiSpec{
Path: "/api/licenses/features",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange path

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@sfwn
Copy link
Member

sfwn commented Dec 28, 2023

/approve

@erda-bot erda-bot merged commit 375dbbb into erda-project:master Dec 28, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants