Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add audit filter and update the default AuditCleanInterval #6166

Merged
merged 9 commits into from
Dec 21, 2023

Conversation

Malyue
Copy link
Collaborator

@Malyue Malyue commented Dec 4, 2023

What this PR does / why we need it:

add audit filter and update the default AuditCleanInterval

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @sfwn

ChangeLog

Language Changelog
🇺🇸 English add audit filter and update the default AuditCleanInterval
🇨🇳 中文 增加审计日志过滤条件和修改组织及系统日志的默认清理时间

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot erda-bot added the bugfix label Dec 4, 2023
@erda-bot erda-bot requested a review from sfwn December 4, 2023 06:35
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 74 lines in your changes are missing coverage. Please review.

Comparison is base (a454bb4) 22.84% compared to head (b4c7c9d) 22.85%.
Report is 11 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #6166    +/-   ##
========================================
  Coverage   22.84%   22.85%            
========================================
  Files        1804     1806     +2     
  Lines      193024   193366   +342     
========================================
+ Hits        44100    44190    +90     
- Misses     143888   144123   +235     
- Partials     5036     5053    +17     
Files Coverage Δ
pkg/arrays/arrays.go 38.09% <100.00%> (+24.76%) ⬆️
...rnal/core/legacy/services/permission/permission.go 4.90% <0.00%> (-0.10%) ⬇️
internal/core/legacy/common/ctxhelper/audit.go 50.00% <50.00%> (ø)
apistructs/audits.go 0.00% <0.00%> (ø)
internal/core/legacy/endpoints/audit.go 0.00% <0.00%> (ø)
internal/core/legacy/services/audit/audit.go 18.95% <57.95%> (ø)

... and 13 files with indirect coverage changes

internal/core/legacy/dao/application.go Outdated Show resolved Hide resolved
internal/core/legacy/endpoints/audit.go Show resolved Hide resolved
internal/core/legacy/model/audit.go Outdated Show resolved Hide resolved
internal/core/legacy/services/audit/audit.go Outdated Show resolved Hide resolved
internal/core/legacy/services/audit/audit.go Outdated Show resolved Hide resolved
cmd/erda-server/conf/i18n/i18n.yaml Outdated Show resolved Hide resolved
cmd/erda-server/conf/i18n/i18n.yaml Outdated Show resolved Hide resolved
internal/core/legacy/endpoints/audit.go Outdated Show resolved Hide resolved
internal/core/legacy/services/audit/audit.go Outdated Show resolved Hide resolved
internal/core/legacy/services/permission/permission.go Outdated Show resolved Hide resolved
internal/core/legacy/services/permission/permission.go Outdated Show resolved Hide resolved
internal/core/legacy/services/audit/audit_test.go Outdated Show resolved Hide resolved
internal/core/legacy/services/permission/permission.go Outdated Show resolved Hide resolved
cmd/erda-server/conf/i18n/i18n.yaml Outdated Show resolved Hide resolved
@Malyue Malyue force-pushed the fix/audit-logs-search branch from 1547977 to a03dc31 Compare December 20, 2023 01:38
@Malyue Malyue force-pushed the fix/audit-logs-search branch from a03dc31 to d30b3e1 Compare December 20, 2023 03:18
@Malyue Malyue force-pushed the fix/audit-logs-search branch from c9fa9fa to b4c7c9d Compare December 21, 2023 07:16
@sfwn
Copy link
Member

sfwn commented Dec 21, 2023

/approve

@erda-bot erda-bot merged commit b6b85ea into erda-project:master Dec 21, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants