Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #6201: fix(gittar): optimize ai code-review #6212

Conversation

erda-bot
Copy link
Member

@erda-bot erda-bot commented Jan 3, 2024

Cherry pick of #6201 on release/2.4-beta.5.

Squashed commit message:

commit 5d67cf0e42d8d9e56312e28b8b0d1b035f5347f2
Author: sfwn <[email protected]>
Date:   Wed Jan 3 14:47:11 2024 +0800

    fix(gittar): optimize ai code-review (#6201)
    
    * limit_sync_group: fix the issue that s.Add blocked when added-items much than maxSize.
    
    The behaviour should be same as sync.WaitGroup: you can add all items just once at first.
    
    * optimize prompt and review result
    
    * replace function-call by normal chat completion
    
    * remove useless code

What this PR does / why we need it:

optimize ai code-review

Which issue(s) this PR fixes:

ChangeLog

Language Changelog
🇺🇸 English optimize ai code-review
🇨🇳 中文 优化 AI 代码审查

Need cherry-pick to release versions?

Add comment like /cherry-pick release/2.4-beta.5 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

* limit_sync_group: fix the issue that s.Add blocked when added-items much than maxSize.

The behaviour should be same as sync.WaitGroup: you can add all items just once at first.

* optimize prompt and review result

* replace function-call by normal chat completion

* remove useless code
@sfwn
Copy link
Member

sfwn commented Jan 3, 2024

/approve

@erda-bot erda-bot merged commit ab37ef6 into erda-project:release/2.4-beta.5 Jan 3, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants