Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace utf8 migration charset to utf8mb4 #6251

Closed

Conversation

chengjoey
Copy link
Contributor

What this PR does / why we need it:

replace utf8 migration charset to utf8mb4

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @luobily

ChangeLog

Language Changelog
🇺🇸 English replace utf8 migration charset to utf8mb4
🇨🇳 中文 将所有migration的默认charset改为utf8mb4

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot erda-bot requested a review from luobily January 23, 2024 06:09
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (827fa3a) 22.62% compared to head (a974015) 22.68%.
Report is 7 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6251      +/-   ##
==========================================
+ Coverage   22.62%   22.68%   +0.06%     
==========================================
  Files        1831     1833       +2     
  Lines      195972   196278     +306     
==========================================
+ Hits        44334    44523     +189     
- Misses     146571   146639      +68     
- Partials     5067     5116      +49     

see 17 files with indirect coverage changes

Copy link
Member

@sfwn sfwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failed to run db migration check: you can not modify files after applied.

I think you should write patch SQLs to adjust charsets.

@chengjoey chengjoey closed this Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants