-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove arch path in single image build #6254
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6254 +/- ##
==========================================
- Coverage 22.69% 22.66% -0.03%
==========================================
Files 1833 1833
Lines 196231 196255 +24
==========================================
- Hits 44526 44484 -42
- Misses 146591 146668 +77
+ Partials 5114 5103 -11 |
We use this arch-in-path to clearly state that this is a single architecture image to prevent it from being mistaken as a multi-architecture image. |
In the development process, pushing paths exceeding two levels is not allowed in non-enterprise repositories. |
ok, please do so. |
Signed-off-by: iutx <[email protected]>
Signed-off-by: iutx <[email protected]>
83486ad
to
5c86022
Compare
Done. Please review the code. |
Signed-off-by: iutx <[email protected]>
Signed-off-by: iutx <[email protected]>
/approve |
What this PR does / why we need it:
Remove arch path in single image build.
Build a single-architecture image without the need for an additional layer of identification; this approach may be utilized in the development environment. For multi-architecture scenarios, utilize
buildx
.Which issue(s) this PR fixes:
Specified Reviewers:
/assign @sfwn
ChangeLog
Need cherry-pick to release versions?
Add comment like
/cherry-pick release/1.0
when this PR is merged.