Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove arch path in single image build #6254

Merged
merged 4 commits into from
Jan 31, 2024

Conversation

iutx
Copy link
Member

@iutx iutx commented Jan 24, 2024

What this PR does / why we need it:

Remove arch path in single image build.

Build a single-architecture image without the need for an additional layer of identification; this approach may be utilized in the development environment. For multi-architecture scenarios, utilize buildx.

image

Which issue(s) this PR fixes:

  • Fixes #your-issue_number
  • [Erda Cloud Issue Link](paste your link here)

Specified Reviewers:

/assign @sfwn

ChangeLog

Language Changelog
🇺🇸 English remove arch path in single image build
🇨🇳 中文 单架构构建移除 arch 路径

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot erda-bot requested a review from sfwn January 24, 2024 02:08
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (36e0f90) 22.69% compared to head (2e1e172) 22.66%.
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6254      +/-   ##
==========================================
- Coverage   22.69%   22.66%   -0.03%     
==========================================
  Files        1833     1833              
  Lines      196231   196255      +24     
==========================================
- Hits        44526    44484      -42     
- Misses     146591   146668      +77     
+ Partials     5114     5103      -11     

see 8 files with indirect coverage changes

@sfwn
Copy link
Member

sfwn commented Jan 30, 2024

We use this arch-in-path to clearly state that this is a single architecture image to prevent it from being mistaken as a multi-architecture image.

@iutx
Copy link
Member Author

iutx commented Jan 31, 2024

We use this arch-in-path to clearly state that this is a single architecture image to prevent it from being mistaken as a multi-architecture image.

In the development process, pushing paths exceeding two levels is not allowed in non-enterprise repositories.
Would it be more reasonable to use tags to identify the architecture?

@sfwn
Copy link
Member

sfwn commented Jan 31, 2024

We use this arch-in-path to clearly state that this is a single architecture image to prevent it from being mistaken as a multi-architecture image.

In the development process, pushing paths exceeding two levels is not allowed in non-enterprise repositories. Would it be more reasonable to use tags to identify the architecture?

ok, please do so.

@iutx iutx force-pushed the chore/remove-arch-path branch from 83486ad to 5c86022 Compare January 31, 2024 03:49
@iutx
Copy link
Member Author

iutx commented Jan 31, 2024

We use this arch-in-path to clearly state that this is a single architecture image to prevent it from being mistaken as a multi-architecture image.

In the development process, pushing paths exceeding two levels is not allowed in non-enterprise repositories. Would it be more reasonable to use tags to identify the architecture?

ok, please do so.

Done. Please review the code.

@sfwn
Copy link
Member

sfwn commented Jan 31, 2024

/approve

@erda-bot erda-bot merged commit f30dc92 into erda-project:master Jan 31, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants