refactor: delete iterations and their sub items together #6264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfwn
requested changes
Feb 4, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6264 +/- ##
==========================================
- Coverage 22.69% 22.65% -0.05%
==========================================
Files 1833 1835 +2
Lines 196128 196666 +538
==========================================
+ Hits 44509 44547 +38
- Misses 146505 146984 +479
- Partials 5114 5135 +21
|
jing-zhi
force-pushed
the
issue-dd
branch
3 times, most recently
from
7f83688 to
c317450
Compare
jing-zhi
force-pushed
the
issue-dd
branch
4 times, most recently
from
baf1bee to
4df13c8
Compare
sfwn
requested changes
Feb 21, 2024
internal/core/openapi/legacy/api/apis/dop/cmdb_iteration_delete.go
Outdated
Show resolved
Hide resolved
jing-zhi
force-pushed
the
issue-dd
branch
2 times, most recently
from
db408cd to
b60764d
Compare
sfwn
requested changes
Feb 23, 2024
sfwn
requested changes
Feb 27, 2024
| if err != nil { | ||
| return apierrors.ErrDeleteIteration.InternalError(err).ToResp(), nil | ||
| } | ||
| goto come |
feat: initialize issueService feat: add option to delete only iterations or all feat: add BatchUpdateIssueIterationID feat: batch deletion of functions and addition of transactions feat: add BatchDeleteIssueByIterationID function feat: expose interfaces refactor: Transaction validation and change the parameter transfer method
sfwn
approved these changes
Feb 27, 2024
|
/approve |
erda-bot
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
refactor: delete iterations and their sub items together
feat: initialize issueService
Which issue(s) this PR fixes:
refactor: delete iterations and their sub items together
Specified Reviewers:
/assign @chengjoey @sfwn @luobily
ChangeLog
Need cherry-pick to release versions?
Add comment like
/cherry-pick release/1.0when this PR is merged.