Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conditions for select registercenter instance from db #6445

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

CeerDecy
Copy link
Member

@CeerDecy CeerDecy commented Sep 27, 2024

What this PR does / why we need it:

fix conditions for select registercenter instance from db

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @iutx

ChangeLog

Language Changelog
🇺🇸 English fix conditions for select registercenter instance from db
🇨🇳 中文 修改查询注册中心实例的查询条件

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot erda-bot requested a review from iutx September 27, 2024 02:56
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 15.12%. Comparing base (d217119) to head (ab421bf).

Files with missing lines Patch % Lines
...l/apps/msp/resource/deploy/handlers/mysql/mysql.go 76.92% 2 Missing and 1 partial ⚠️
...nternal/tools/orchestrator/services/addon/addon.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6445   +/-   ##
=======================================
  Coverage   15.12%   15.12%           
=======================================
  Files        3675     3675           
  Lines      377005   377020   +15     
=======================================
+ Hits        57018    57030   +12     
- Misses     314540   314543    +3     
  Partials     5447     5447           
Flag Coverage Δ
by-github-actions 15.12% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nternal/tools/orchestrator/services/addon/addon.go 13.55% <0.00%> (-0.01%) ⬇️
...l/apps/msp/resource/deploy/handlers/mysql/mysql.go 11.41% <76.92%> (+2.73%) ⬆️

... and 7 files with indirect coverage changes

Copy link
Member

@iutx iutx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

internal/apps/msp/resource/deploy/handlers/mysql/mysql.go Outdated Show resolved Hide resolved
@CeerDecy CeerDecy requested a review from iutx October 28, 2024 06:14
Copy link

stale bot commented Nov 23, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 23, 2024
@CeerDecy CeerDecy removed the wontfix label Nov 28, 2024
Copy link
Member

@iutx iutx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CeerDecy CeerDecy requested a review from iutx December 16, 2024 08:20
@CeerDecy CeerDecy force-pushed the fix/register-addon-instance branch from 714537e to ab421bf Compare December 18, 2024 06:44
Copy link
Member

@iutx iutx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants