Cleaned up selection of librato metics #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks pretty sweet. Thanks! |
This was referenced Aug 7, 2012
|
hey, what happened to the pull request? just read through the related issues and couldn't find a hint why this isn't merged yet. how can i help to get this merged? |
|
I've recently started on a better librato reporter here: https://github.com/eric/metriks-librato_metrics On Mon, Sep 30, 2013 at 3:55 AM, Benjamin Fritsch
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took Ryanlower's selection code, (#9) made the necessary checks for empty filters, and added a few tests to cover the new cases. Did a very simple extract-method to support the tests.