Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use concurrent-ruby #54

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

svenfuchs
Copy link

I'm not 100% certain, but my understanding is that Concurrent:: AtomicReference provides what Atomic used to be.

@svenfuchs svenfuchs force-pushed the sf-use-concurrent-ruby branch from 156c009 to cf65aaa Compare April 25, 2017 16:58
@svenfuchs svenfuchs force-pushed the sf-use-concurrent-ruby branch from cf65aaa to 9c18178 Compare April 25, 2017 17:00
@eric
Copy link
Owner

eric commented Apr 25, 2017

Were you running into problems with this? I was trying to not remove 1.8 support unless it was nessesary, and the new concurrent gem doesn't support 1.8.

@svenfuchs
Copy link
Author

svenfuchs commented May 19, 2017

@eric sorry, totally missed your response before :/

not actual problems, but atomic is deprecated/eol, and not tested against >= 2.3 any more https://github.com/ruby-concurrency/atomic/blob/master/.travis.yml

not a lot of development has happened between late 2014 and today, which seems to indicate that things are pretty stable?

would you consider releasing 1.0.0 from the current version/master (to have something stable enough supported for versions < 1.9.3) and then go to 1.1.0 for removing the deprecated dependency?

@svenfuchs
Copy link
Author

forgot to mention that, IIRC, what triggered this on our side were deprecation warnings about constant ::Fixnum is deprecated (would have to verify this though)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants