Skip to content
This repository has been archived by the owner on Nov 21, 2020. It is now read-only.

Change dockerfile to make full build inside container [WIP] #711

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

theikkila
Copy link
Contributor

Currently image is built in CI-pipeline so that first steps are made outside dockerfile and only the built distribution is moved in.

That causes however problems if somebody would like to build the image without the full CI-pipeline.

This is WIP, it works already but it produces very large images.

@ghost
Copy link

ghost commented Jan 30, 2020

DeepCode's analysis on #854e95 found:

  • 0 critical issues. ⚠️ 0 warnings and 0 minor issues. ✔️ 0 issues were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


☺️ If you want to provide feedback on our bot, here is how to contact us.

@shinebayar-g
Copy link
Contributor

shinebayar-g commented Feb 1, 2020

If you actually compare our docker images and this new image, only src directory will be copied additionally. So I don't think this new images will be fat. yarn install & yarn build steps are moved outside of dockerfile to use CI features such as caching.

I don't think it's good idea to add those steps back into Dockerfile that CI uses. It'll create duplicate steps. Instead I'd suggest to create another Dockerfile for development & custom image purposes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants