Skip to content
This repository has been archived by the owner on Nov 21, 2020. It is now read-only.

Implemented user assigned isolation #740

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jrrcdev
Copy link

@jrrcdev jrrcdev commented Mar 21, 2020

We have implemented an user assigned chat isolation option to follow this behavior:

1 - New chat appears for every one in the channel(no assigned user)
2 - An user assumes the chat, meaning he is assigned to that chat
3 - Chat with the new designated user "disappears" from other users
4 - If need, the user previous assigned or the admin, can assign other user to continue the chat(like a transfer)

We also made a change (in the option "USE_BRAND_RESTRICTIONS") on user selection by brand because the behavior wasn't loading the users correctly in this situations:

  • Current logged user profile has an empty array on "brandIds" property
  • User hasn't the "brandIds" property or has an empty array

Expected behavior: If user has no brand, it should load all brands

To use this behavior, you should set the ENV property "USE_CHAT_RESTRICTIONS" to "true"

.env file:
USE_CHAT_RESTRICTIONS=true

@ghost
Copy link

ghost commented Mar 21, 2020

Congratulations 🍻. DeepCode analyzed your code in 0.382 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


☺️ If you want to provide feedback on our bot, here is how to contact us.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant